Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transaction request #37
transaction request #37
Changes from 1 commit
04e541d
19451fc
4dd53f4
207423a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1 in src/effects/effects_for_transaction_request.rs
GitHub Actions / Build and test Stellar SDK
Check warning on line 1 in src/effects/effects_for_transaction_request.rs
GitHub Actions / Build and test Stellar SDK
Check warning on line 818 in src/horizon_client.rs
GitHub Actions / Build and test Stellar SDK
Check warning on line 1944 in src/horizon_client.rs
GitHub Actions / Build and test Stellar SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Het ophalen van het eerste record zou ik 1 keer doen. En dan hergebruiken over alle onderliggende asserts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lijkt me handig om dit ook bij meerdere endpoints in een keer te doen bij dezelfde refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik zie m toch liever nu al mee in deze pr, opdat we het niet vergeten.