Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Offer Endpoint #42

Closed
wants to merge 14 commits into from
Closed

Single Offer Endpoint #42

wants to merge 14 commits into from

Conversation

kevin-pease
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Adds the endpoint for single Offers requests. Includes documentation and unit tests. Doesn't include the other Offers endpoints yet, to keep this PR's size manageable. These endpoints will be included in future PR's.

⤵️ What is the current behavior?

No Offers endpoints are implemented yet.

🆕 What is the new behavior (if this is a feature change)?

The endpoint for single offers is implemented.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current main

@tluijken tluijken force-pushed the single-offer-endpoint branch from 62b550a to 7b55283 Compare April 8, 2024 11:09
/// [`HorizonClient::get_single_offer`](crate::horizon_client::HorizonClient::get_single_offer) method.
///
/// The struct matches the parameters necessary to construct a request for the
/// <a href="https://developers.stellar.org/network/horizon/resources/get-offer-by-offer-id">Retrieve An Offer endpoint</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik had de link gecheckt; deze werkt volgens mij gewoon.

Copy link
Collaborator

@tluijken tluijken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netjes Kevin!!

@LeonardTibben LeonardTibben self-requested a review April 26, 2024 09:25
@kevin-pease kevin-pease mentioned this pull request Apr 29, 2024
4 tasks
@kevin-pease kevin-pease closed this May 8, 2024
@kevin-pease kevin-pease deleted the single-offer-endpoint branch July 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants