Fix: Reseed Whitelist #1067
Merged
Fix: Reseed Whitelist #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
Brean0
approved these changes
Sep 10, 2024
| await well | ||
| .connect(account) | ||
| .addLiquidity([beanAmounts[i], nonBeanAmounts[i]], 0, L2Beanstalk, MAX_UINT256); | ||
| // perform a swap to update the well pumps and avoid "NotInitialized" error. | ||
| await well.connect(account).swapFrom(bean.address, token.address, to6("1"), 0, account.address, MAX_UINT256); |
There was a problem hiding this comment.
apologies, instead of swapping 1 bean here, I think we should call it with 0 beans instead (which should initialize the pump as well)
I would do this with addLiquidity(with 0) as thats what was done in the past.
There was a problem hiding this comment.
Fixed here and it worked: 92a65bb. Merging this now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses the
BeanstalkPricecontract failing along with whitelist data errors in the reseed.ReseedWhitelist.solto set the oracle implementation for the non bean token in the well instead of the well lp token.NotInitialized()error.