add CI testing #1
Conversation
.github/workflows/test.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
you can also add "3.11" here
There was a problem hiding this comment.
Shouldn't we keep it so that the mirror doesn't break? I think Anil left the gitlab-ci file in the github of bluecellulab.
There was a problem hiding this comment.
Oh, ok. You need to keep a mirror on gitlab to run some tests, am I understanding this correctly?
There was a problem hiding this comment.
I'm not sure yet, maybe we can keep it for the moment?
| @@ -34,8 +34,6 @@ | |||
| EXTRA_LUIGI = [ | |||
| "luigi>=3.0", | |||
| "luigi-tools>=0.0.12", | |||
| "bbp-workflow>=2.1.19", | |||
There was a problem hiding this comment.
Maybe you should not remove that, we have some bbp-worklow import in bluepyemodel.tasks.luigi_tools
There was a problem hiding this comment.
The CI still tries to install it and since it's private it can't find it, maybe we should comment it?
There was a problem hiding this comment.
They are still dependencies, so we should not remove them from the setup.py. We can just replace extra: all in tox by only the needed extras. lint might fail with some dependencies not found error, because it did not find bbp workflow, and we can just add an ignore this pylint warning in the code
There was a problem hiding this comment.
Or maybe we can remove them, and do a try/except explaining that it is the user responsability to install bbp-workflow
There was a problem hiding this comment.
Or maybe we can remove them, and do a try/except explaining that it is the user responsability to install bbp-workflow
yes since we we did for bluepyemodelnexus, I think it would make sense for those as well to do it like that
|
You can also remove the PIP_INDEX_URL and the PIP_EXTRA_INDEX_URL from tox.ini, unless you need to keep it for mirroring and stuff |
No description provided.