Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add python dynamical feature registration #391

Merged
merged 6 commits into from
May 13, 2024
Merged

Conversation

arnaudon
Copy link
Contributor

@arnaudon arnaudon commented May 7, 2024

This could made possible to try experimental new features, or very specific ones which don't make sense to be used in general, but for a very specific project.

It would be nice to make _get_cpp_data public, but I'm not sure if this is ok to do?

@arnaudon arnaudon requested a review from anilbey May 7, 2024 11:48
tests/test_basic.py Outdated Show resolved Hide resolved
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@arnaudon
Copy link
Contributor Author

it works in parallel, if register is done in the script, not under main .

@arnaudon arnaudon mentioned this pull request May 13, 2024
3 tasks
@arnaudon arnaudon merged commit 85f69f5 into master May 13, 2024
20 checks passed
@arnaudon arnaudon deleted the register_features branch May 13, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants