Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-processing tutorial with VRG information #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pre-processing tutorial with VRG information #202

wants to merge 1 commit into from

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Aug 30, 2023 •
edited
Loading

@NicerNewerCar NicerNewerCar mentioned this pull request Aug 30, 2023
Merged
3 tasks
@NicerNewerCar NicerNewerCar requested a review from jcfr September 27, 2023 13:32
jcfr
jcfr reviewed Dec 4, 2023
View reviewed changes
Documentation/tutorials/pre-processing-module.md Outdated Show resolved Hide resolved
Documentation/tutorials/pre-processing-module.md
To access the Pre-Processing module, open the AutoscoperM module located in the `Tracking` category. Next, navigate to the second tab labeled `Autoscoper Pre-Processing`.
To access the Pre-Processing module, open the AutoscoperM module located in the `Tracking` category. Next, navigate to the second tab labeled `Autoscoper Pre-Processing`. The UI is broken into six sections: General Inputs, Segmentation Generation, VRG Generation - Manual Camera Placement, VRG Generation - Automatic Camera Placement, Partial Volume Generation, and Config file Generation.

![UI Overview](https://github.com/BrownBiomechanics/Autoscoper/releases/download/docs-resources/prePro_overview.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Documentation/tutorials/pre-processing-module.md Outdated Show resolved Hide resolved
Documentation/tutorials/pre-processing-module.md Show resolved Hide resolved
Documentation/tutorials/pre-processing-module.md Outdated Show resolved Hide resolved
Documentation/tutorials/pre-processing-module.md Outdated Show resolved Hide resolved
@jcfr
Copy link
Contributor

jcfr commented Dec 4, 2023

I think this should be split into:

  • description of the pre-processing capabilities
  • tutorial making use of these new capabilities and referencing sample data that could be used

Since the current documentation only describes the Autoscoper UI and let the reader discover the AutoscoperM UI through the tutorials, the documentation approach used here makes sense.

We should revisit the section User Interface1 section to explicitly describe that there will be two UIs:

  • the module panel available in Slicer
  • the Autoscoper UI

Footnotes

  1. https://autoscoper.readthedocs.io/en/latest/user-interface.html ↩

@amymmorton amymmorton closed this Nov 22, 2024
@amymmorton
Copy link
Collaborator

Preprocessing tutorial is de still needed -

But the vrg:
Suggest make as depreciated in favor of #99

@amymmorton amymmorton reopened this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr jcfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicerNewerCar @jcfr @amymmorton