Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Radiograph Generation Module #53

Merged
merged 9 commits into from
Dec 5, 2023

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Aug 17, 2023

Static 3DCT Radiograph generation support

  • This PR enables the support of virtual radiograph (VRG) generation of static 3DCT volumes
  • Allows for VRG generation to use either manually placed cameras (markup fiducials) or automatically optimized cameras
  • Adds CalculateDataIntensityDensity CLI module
    • For evaluating each VRG
  • Adds VirtualRadiographGeneration CLI module
    • For rendering a VRG using VTK
  • Updates the pre-processing tab to use the above CLI modules
  • After this is integrated two follow-up PRs will be opened
    • To add a CLI module to perform segmentation
    • To add support for Sequential 3DCT and 4DCT

Final ToDo:

@NicerNewerCar NicerNewerCar force-pushed the vrg-gen branch 4 times, most recently from fe9041c to 7ab6cbf Compare August 18, 2023 18:43
@NicerNewerCar NicerNewerCar force-pushed the vrg-gen branch 3 times, most recently from a14f6ab to 7002eee Compare August 28, 2023 19:25
@NicerNewerCar NicerNewerCar marked this pull request as ready for review August 28, 2023 19:26
@NicerNewerCar NicerNewerCar requested a review from jcfr August 28, 2023 19:26
@amymmorton
Copy link
Contributor

Awesome, all tabs tested with PRE PROC LEFT Hop Knee .
vrgGenSuces

@amymmorton
Copy link
Contributor

When existing- had issues:

onExit

@NicerNewerCar
Copy link
Contributor Author

When existing- had issues:

onExit

Already fixed see #52

.pre-commit-config.yaml Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Show resolved Hide resolved
virtualRadiographGeneration/virtualRadiographGeneration.py Outdated Show resolved Hide resolved
@NicerNewerCar NicerNewerCar force-pushed the vrg-gen branch 7 times, most recently from 8bfeca2 to fa01af7 Compare September 18, 2023 15:15
@NicerNewerCar NicerNewerCar force-pushed the vrg-gen branch 2 times, most recently from ad22f59 to 83dd492 Compare September 25, 2023 13:35
@NicerNewerCar NicerNewerCar requested a review from jcfr September 25, 2023 13:36
@NicerNewerCar NicerNewerCar force-pushed the vrg-gen branch 3 times, most recently from 5d24eb2 to 2ec63eb Compare September 26, 2023 17:43
@amymmorton
Copy link
Contributor

On launch:
dllLoaderr_vrggen

Where did we land with the batch generation of multiple volumes? For a given series of 3d volumes- we'll want to process and create a cfg

vols

@NicerNewerCar
Copy link
Contributor Author

Where did we land with the batch generation of multiple volumes? For a given series of 3d volumes- we'll want to process and create a cfg

I think it makes the most sense to include the 3d series with the 4DCT PR since Slice represents them with the same data structure.

@amymmorton
Copy link
Contributor

vtk_vrg
0

The auto cam placement seems to have stalled/crashed at 40%:
crash40

@NicerNewerCar
Copy link
Contributor Author

Fixed the stalling, with the auto placement.

@NicerNewerCar NicerNewerCar force-pushed the vrg-gen branch 2 times, most recently from da8e480 to 3233943 Compare November 27, 2023 17:30
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local build reports the following:

CMake Error at CMakeLists.txt:56 (add_subdirectory):
  add_subdirectory given source "CalculateDataIntensityDensity" which is not
  an existing directory.


CMake Error at CMakeLists.txt:57 (add_subdirectory):
  add_subdirectory given source "VirtualRadiographGeneration" which is not an
  existing directory.

@jcfr
Copy link
Contributor

jcfr commented Dec 4, 2023

I am addressing the issues

calculateDataIntensityDensity -> CalculateDataIntensityDensity
virtualRadiographGeneration -> VirtualRadiographGeneration

@jcfr jcfr force-pushed the vrg-gen branch 2 times, most recently from 86a0e97 to 66f93a6 Compare December 4, 2023 17:53
@jcfr
Copy link
Contributor

jcfr commented Dec 4, 2023

Renamed modules:

  • calculateDataIntensityDensity -> CalculateDataIntensityDensity
  • virtualRadiographGeneration -> VirtualRadiographGeneration

Rename VirtualRadiographGeneration parameters:

  • outputFName -> outputFileName
  • width -> outputWidth
  • height -> outputHeight

Update check of CalculateDataIntensityDensity parameters to be consistent with how CalculateDataIntensityDensity are checked.

@jcfr jcfr force-pushed the vrg-gen branch 2 times, most recently from abf9e7c to 5a48be1 Compare December 4, 2023 17:59
@jcfr
Copy link
Contributor

jcfr commented Dec 4, 2023

Since the CLI are not directly used, I also suggest to move the CLI modules into a called Tracking.Advanced:

How does that sound ?

@NicerNewerCar
Copy link
Contributor Author

Since the CLI are not directly used, I also suggest to move the CLI modules into a called Tracking.Advanced:

How does that sound ?

Makes sense, I think that's fine.

Copy link
Contributor Author

@NicerNewerCar NicerNewerCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfr Just a couple of notes the CLI variable names, once those are address I think this is good to go

AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
@jcfr jcfr merged commit f97a739 into BrownBiomechanics:main Dec 5, 2023
2 checks passed
@NicerNewerCar NicerNewerCar deleted the vrg-gen branch December 5, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants