BUG: Remove obsolete VRG Generation functionality #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbelsk
force-pushed
the
remove-VRG-generation
branch
from
4cc2a14 to
34a9c6e
Compare
2 tasks
jcfr
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Thanks for working on those changes 🙏
Beside of few minor nitpicks, it will be good for integration
In the commit message, could you also provide the rational for removing the removing the features ? (e.g superseded by the integration of hierarchical registration allowing to ...)
sbelsk
force-pushed
the
remove-VRG-generation
branch
from
34a9c6e to
a7310b0
Compare
jcfr
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Thanks for addressing the comments 🙏
I suggest to further tweak the commit message and pull request description to include the rational. Feel free to tweak/adapt as you see fit.
Removes the 'Manual Camera Placement' and 'Automatic Camera Placement'
VRG Generation UI groups from the Pre-Processing modules, along with all
of their associated backend code. This includes the removal of the
CalculateDataIntensityDensity and VirtualRadiographGeneration modules.
+ The support for camera placement is superseded by the hierarchical registration capability.
sbelsk
force-pushed
the
remove-VRG-generation
branch
from
a7310b0 to
3ade5fc
Compare
Removes the 'Manual Camera Placement' and 'Automatic Camera Placement' VRG Generation UI groups from the Pre-Processing modules, along with all of their associated backend code. This includes the removal of the CalculateDataIntensityDensity and VirtualRadiographGeneration modules. The support for camera placement is superseded by the hierarchical registration capability.
jcfr
force-pushed
the
remove-VRG-generation
branch
from
3ade5fc to
9f5e88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132.
This PR removes the 'Manual Camera Placement' and 'Automatic Camera Placement' VRG Generation UI groups from the Pre-Processing modules, along with all of their associated backend code. This includes the removal of the
CalculateDataIntensityDensityandVirtualRadiographGenerationmodules.The support for camera placement is superseded by the hierarchical registration capability.