-
Notifications
You must be signed in to change notification settings - Fork 1k
fix[ENG-8003]: Changing the entry on a symbol does not update the preview window #3985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…If not equal than fetchSymbolContent
🦋 Changeset detectedLatest commit: eb5362f The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit eb5362f.
☁️ Nx Cloud last updated this comment at |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11707119 | Triggered | Generic High Entropy Secret | c3245e0 | packages/sdks/snippets/svelte/src/components/blueprints/BlogArticle.svelte | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're missing a few things, i created a loom explaining what all changes you need to do so that you can properly mock the fetch calls
https://www.loom.com/share/62e673c3668342949f1df71b72b921f3
let me know if you have any questions
Interestingly, when I run them individually, my fix resolves the issue, but the test case still fails. I’m wondering if I’m missing something. I’ve recorded a Loom https://www.loom.com/share/ac1bd9c4d6c346efa3899250ce9b8220?sid=25f81646-040e-4c42-856b-ed13d938e772 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! requires a changeset
Co-authored-by: Sidharth Mohanty <sidmohanty11@gmail.com>
Description
This PR fixes an issue where symbol content was not updating correctly. The fix compares the previous symbol entry with the incoming symbol entry—if they are not equal, it triggers
fetchSymbolContent
to ensure the latest content is loaded.Changes Made:
fetchSymbolContent
if the entries differ to update the content.Why This Change Was Made:
To ensure symbol content updates correctly when the symbol entry changes, improving accuracy and consistency in the preview.
Loom
https://www.loom.com/share/032123ec4a7f449db7690eb9ca022f3e?sid=3964bfa8-ac48-428a-a376-91568c447213