-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix[ENG-8003]: Changing the entry on a symbol does not update the preview window #3985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
59e21f1
fix: comparing the previous symbol entry with incoming symbol entry. …
yash-builder fd2ad92
fix: updating the state of symbol entry once changed
yash-builder 93a6d2f
wip: adding test cases
yash-builder 0e6366d
feat: Added test case
yash-builder 08b02e6
fix: remove .only from test case
yash-builder 0ad71f6
fix: remove console
yash-builder e44b0ff
fix: improved test cases
yash-builder f22ad78
Merge branch 'main' into ENG-8003
yash-builder c3245e0
Merge branch 'main' into ENG-8003
yash-builder 6762c62
docs: changesets
yash-builder eb5362f
Update .changeset/nasty-pants-cheat.md
yash-builder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
packages/sdks-tests/src/specs/get-content-symbol-update-entry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
|
||
export const GET_CONTENT_SYMBOL_UPDATE_ENTRY_ONE = { | ||
data: { | ||
blocks: [ | ||
{ | ||
'@type': '@builder.io/sdk:Element', | ||
'@version': 2, | ||
id: 'builder-d3b5d8a50eff41e7a24cce1b82abd8fe', | ||
component: { name: 'Text', options: { text: 'Green Potato' } }, | ||
responsiveStyles: { | ||
large: { | ||
display: 'flex', | ||
flexDirection: 'column', | ||
position: 'relative', | ||
flexShrink: '0', | ||
boxSizing: 'border-box', | ||
marginTop: '20px', | ||
lineHeight: 'normal', | ||
height: 'auto', | ||
}, | ||
}, | ||
}, | ||
], | ||
} | ||
} | ||
|
||
|
||
export const MAIN_CONTENT = { | ||
data: { | ||
inputs: [], | ||
themeId: false, | ||
title: 'symbol with locale', | ||
blocks: [ | ||
{ | ||
'@type': '@builder.io/sdk:Element', | ||
'@version': 2, | ||
id: 'builder-29bab71fac7043eb921eb530a3203e5f', | ||
component: { | ||
name: 'Symbol', | ||
options: { | ||
symbol: { | ||
entry: 'e2a166f7d9544ed9ade283abf9491af3', | ||
model: 'symbol', | ||
data: {}, | ||
}, | ||
}, | ||
}, | ||
responsiveStyles: { | ||
large: { | ||
display: 'flex', | ||
flexDirection: 'column', | ||
position: 'relative', | ||
flexShrink: '0', | ||
boxSizing: 'border-box', | ||
}, | ||
}, | ||
}, | ||
], | ||
}, | ||
}; | ||
|
||
export const GET_CONTENT_SYMBOL_UPDATE_ENTRY__TWO = { | ||
data: { | ||
blocks: [ | ||
{ | ||
'@type': '@builder.io/sdk:Element', | ||
'@version': 2, | ||
id: 'builder-fb1550e198b84b6089fdc977a393f208', | ||
component: { name: 'Text', options: { text: 'Red tomato' } }, | ||
responsiveStyles: { | ||
large: { | ||
display: 'flex', | ||
flexDirection: 'column', | ||
position: 'relative', | ||
flexShrink: '0', | ||
boxSizing: 'border-box', | ||
marginTop: '20px', | ||
lineHeight: 'normal', | ||
height: 'auto', | ||
}, | ||
}, | ||
}, | ||
], | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.