Replace pg_edgeidx_dsl mask by multiplying with 0.0

[havogt]

When naively translating a Fortran list to a full field, we constructed a mask instead of using the fact that we are actually initializing a weight with 0.0 in the masked-out cases.

Additionally: Remove program and a trivial test.

[havogt]

cscs-ci run default

[havogt]

cscs-ci run default

[havogt]

cscs-ci run default

[havogt]

Should we create a separate fix in icon-exclaim for this or just accumulate the changes with the other changes from #1052?

[muellch]

The only concern I have is that this might degrade performance.
The GPU might load all the data for the whole computation

 z_gradh_exner + z_hydro_corr * pg_exdist

instead of one bool per thread.
A performance measurement would help here.

[github-actions]

Mandatory Tests

Please make sure you run these tests via comment before you merge!

• cscs-ci run default
• cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

• cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

• cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

• cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

[havogt]

cscs-ci run default

[jcanton]

Good catch!
LGTM after @muellch performance verification

[jcanton]

Should we create a separate fix in icon-exclaim for this or just accumulate the changes with the other changes from #1052?

let's accumulate, otherwise I spend the cycle fixing merge conflicts ;-)