Conversation
|
I would also update the minimum required version in |
|
@havogt already knows, but just for the record for others: while we'll try to make a new tag/version of GHEX soon with ghex-org/GHEX#184 and ghex-org/GHEX#182, the changes from ghex-org/GHEX#186 (i.e. the |
|
I went for ghex >= 0.5, a version that doesn't exist on pypi. The reason is that the current change is not compatible (because of the missing sync) with any release. I.e. the user will get at least an error when trying to install from pypi. |
msimberg
left a comment
There was a problem hiding this comment.
Not much to say from my side. The version constraint looks sensible to me.
|
cscs-ci run default |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
blueline verified with mch_ch2 |
Note: This version of GHEX avoids the sync in icon4py that is needed with GHEX v0.4.1, giving a huge boost in performance. The minimum version of ghex is set to 0.5, which is not currently released, but might become the version with the async scheduling feature.