Skip to content

GHEX update#941

Closed
halungge wants to merge 1 commit intomainfrom
update_ghex_version
Closed

GHEX update#941
halungge wants to merge 1 commit intomainfrom
update_ghex_version

Conversation

@halungge
Copy link
Contributor

change GHEX to latest release version on PyPI,
use ghex github master…in uv.sources

@halungge halungge requested a review from egparedes November 12, 2025 09:42
@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@havogt
Copy link
Contributor

havogt commented Nov 12, 2025

I would like to merge #938 instead. We discussed that @msimberg will keep that branch stable and I believe it's good to test it more, as we anyway want to use it for the coupled runs.

egparedes
egparedes previously approved these changes Nov 12, 2025
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @havogt about merging #938 instead, but I would add there the change in the common pyproject.toml to bump the minimal required version of ghex to the latest version available in PyPi: "ghex>=0.4.1"

@egparedes egparedes self-requested a review November 12, 2025 14:11
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved earlier by mistake, we should merge #938 instead

@egparedes egparedes dismissed their stale review November 12, 2025 14:19

We should merge #938 instead

@halungge halungge closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants