Issue 471: Add TransfromObservationModel #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="transform-obs-model", subdir="EpiAware")
using EpiAware |
SamuelBrand1
requested changes
Oct 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
=======================================
Coverage 89.87% 89.88%
=======================================
Files 51 52 +1
Lines 741 751 +10
=======================================
+ Hits 666 675 +9
- Misses 75 76 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 11, 2024
|
Hmm does this repeat failure indicate we should change the test? |
|
@SamuelBrand1 thoughts on something to change here to make this safer for merging |
What was the fail? |
|
its an inexact error for the benchmark for this feature which given its simplicity I find very confusing |
Not sure what is causing this, but its quite a wild error in benchmarks |
|
Any idea if this is actually related to this PR or if its something from the numerical stability issues? If it is this PR any thoughts? It would be good to get this merged |
I'm 70% its this PR because such a large benchmark error would IMO likely have been caught already. I'm running locally to have a closer look. |
|
Could be a |
|
The error in the benchmarking is happening at the |
|
To specify I already located it to this newly added benchmark so it is definitely the problem |
I'm still at a bit of a lose about why this is problematic for the |
|
@SamuelBrand1 can you take a look at this and see if you can spot the problem? It would be great to be able to merge. this |
EpiAware/src/EpiObsModels/modifiers/TransformObservationModel.jl
Outdated
Show resolved
Hide resolved
SamuelBrand1
previously approved these changes
Oct 24, 2024
Co-authored-by: Samuel Brand <48288458+SamuelBrand1@users.noreply.github.com>
SamuelBrand1
previously approved these changes
Oct 24, 2024
SamuelBrand1
approved these changes
Oct 24, 2024
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
SamuelBrand1
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
TransformObservationModelin the same style asTransformLatentModels. It helps to address #471.I noted during this PR that the obs models names are getting very long and unwieldy. One obvious way to address this would be to use obs everywhere. I also think we should update
TransformLatentModelsto have a transform argument to match that used here.