Feature/dev 50419 #2142
Merged
Feature/dev 50419 #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR optimizes the
formatLegendLocationhelper function in formatLegendLocation.ts by improving how county key lookups are performed.Details
Previously, the function recreated an array of county keys and used
.includes()on every call. This has been replaced with aSet(countyKeySet) that is created once at module load, allowing for faster.has()lookups.The logic and output of
formatLegendLocationremain the same. Only the internal implementation has changed for efficiency and code clarity.Benefits
Testing Steps
Add/Remove the diff to see the performance improvement on county maps here:
No other files or logic were affected.