Skip to content

Comments

Cleaned up basic-infection. Fixes #239.#274

Closed
RobertJacobsonCDC wants to merge 2 commits intomainfrom
RobertJacobsonCDC_239_clean_up_basic_infection
Closed

Cleaned up basic-infection. Fixes #239.#274
RobertJacobsonCDC wants to merge 2 commits intomainfrom
RobertJacobsonCDC_239_clean_up_basic_infection

Conversation

@RobertJacobsonCDC
Copy link
Collaborator

Moved disease_model from the docs to examples and made a symlink in the docs.

The disease_model example replaces basic-infection; basic-infection is still used as a benchmark.

It is probably wise to wait to merge this until #214 and #215 are merged, because this PR will have to modify changes to workflows modified by those PRs.

…he docs.

The disease_model example replaces basic-infection; basic-infection is still used as a benchmark.
…ommit adds enough `allow` annotations to get them to pass.
@RobertJacobsonCDC
Copy link
Collaborator Author

Some frustrating issues:

  • Because of limitations in Cargo, we cannot run disease_model with cargo run --example disease_model, because disease_model is itself structured as a package.
  • Clippy breaks if I include disease_model as a binary in Cargo.toml ([[bin]] name = disease_model). In particular, it doesn't "see" dev dependencies.
  • Clippy goes bananas on the benchmark's test modules. I added allow to everything in the test modules to get them to pass because of false positives.

I think structuring the project will fix these issues, but I'd have to try it to be sure.

@RobertJacobsonCDC RobertJacobsonCDC added the blocked Currently blocked by another issue label Mar 12, 2025
@RobertJacobsonCDC RobertJacobsonCDC marked this pull request as ready for review March 17, 2025 16:04
@k88hudson-cfa k88hudson-cfa removed the blocked Currently blocked by another issue label Apr 28, 2025
@k88hudson-cfa
Copy link
Collaborator

This looks like it's resolved to me as of 1c17d9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants