feat: Going turbofishing (adds the with! macro and implements query for entity ZSTs) #793
Open
k88hudson-cfa wants to merge 8 commits intomainfrom
Open
feat: Going turbofishing (adds the with! macro and implements query for entity ZSTs) #793k88hudson-cfa wants to merge 8 commits intomainfrom
k88hudson-cfa wants to merge 8 commits intomainfrom
Conversation
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd actually argue we take out (or at least deprecate) the tuple syntax altogether and replace it with a macro/ZST (controversial I know)! My argument is that it's gets rid of the akward turbofish and trailing
,when adding entities, sample_entity, and any other method that takes queries, and it's fairly natural to read.We could do
q!but I thought maybe we should add it later when we add other variants (like and, or) so we don't have a second breaking change. Wdyt?I updated the docs but didn't take out the old tuple impl yet, I wanted to get thoughts first. Otherwise, it's ready for review