Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out deprecated values #1624

Closed
wants to merge 3 commits into from
Closed

Swap out deprecated values #1624

wants to merge 3 commits into from

Conversation

pluckyswan
Copy link
Contributor

@pluckyswan pluckyswan commented Nov 27, 2024

Description

GitHub actions is showing warnings for soon-to-be deprecated terraform attributes. This PR will replace them, specifically storage_account_name and resource_manager_id.

Issue

#1610

Checklist

Note: You may remove items that are not applicable

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Variable Update
Ensure that the updated variable storage_account_id and scope are correctly configured and do not cause any access or functional issues with the storage account and role assignments.

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@pluckyswan
Copy link
Contributor Author

This error occurs when deploying in PR and internal for the first time. It goes away when re-ran.
Screenshot 2024-11-27 at 11 49 13 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant