Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added table of contents to readme #1638

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Added table of contents to readme #1638

merged 4 commits into from
Dec 10, 2024

Conversation

jherrflexion
Copy link
Contributor

@jherrflexion jherrflexion commented Dec 2, 2024 •
edited
Loading

Description

Added table of contents to readme

@jherrflexion jherrflexion self-assigned this Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

basiliskus
basiliskus reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to spend more time reviewing later, but it seems a few sections are missing. I noticed the RS setup section is gone

README.md Outdated Show resolved Hide resolved
@jherrflexion jherrflexion changed the title Updated Readme to be more readable Added table of contents to readme Dec 6, 2024
@jherrflexion @pluckyswan @saquino0827
Changed PR to only add table of contents
ad07262 
Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

luis-pabon-tf
luis-pabon-tf approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@luis-pabon-tf luis-pabon-tf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sections are in the readme and it works good.

tjohnson7021
tjohnson7021 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@tjohnson7021 tjohnson7021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@jherrflexion jherrflexion merged commit 83e4aa7 into main Dec 10, 2024
17 checks passed
@jherrflexion jherrflexion deleted the no-merge-conflict-read-me-branch branch December 10, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halprin halprin halprin left review comments

@basiliskus basiliskus basiliskus left review comments

@tjohnson7021 tjohnson7021 tjohnson7021 approved these changes

@luis-pabon-tf luis-pabon-tf luis-pabon-tf approved these changes

@saquino0827 saquino0827 Awaiting requested review from saquino0827

Assignees

@jherrflexion jherrflexion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jherrflexion @basiliskus @luis-pabon-tf @halprin @saquino0827 @tjohnson7021