Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated snapshot examples files #1645

Closed
wants to merge 3 commits into from
Closed

Conversation

saquino0827
Copy link
Contributor

Description

  • Ran the update-examples-snapshot.sh and updated all our example files.
  • Includes new LA sample files.

Issue

1355

Note: You may remove items that are not applicable

@saquino0827
Copy link
Contributor Author

I may need to back track some of the other example files changes. It looks like only ID's were updated in some examples. The main purpose of this PR was to upload the example/LA files

Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link

github-actions bot commented Dec 6, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1355 - Partially compliant

Fully compliant requirements:

  • The OBR for "54089-8" remains unchanged
  • All other OBR are removed from the outgoing HL7 ORU message
  • All OBXs appear under the sole remaining OBR
  • Numeric OBX IDs are sequential and unique

Not compliant requirements:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Missing E2E Test
The PR does not include the required end-to-end test for the transformation, which is a critical part of the acceptance criteria.

Copy link

github-actions bot commented Dec 6, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

@basiliskus
Copy link
Contributor

I may need to back track some of the other example files changes. It looks like only ID's were updated in some examples. The main purpose of this PR was to upload the example/LA files

@saquino0827 It looks good to me. The IDs for the FHIR resources will always change when updating the files because they are randomly generated when RS creates the FHIR message. Unless you are referring to other IDs

@saquino0827
Copy link
Contributor Author

I opened a PR for the wrong branch. Closing this PR for now.

@saquino0827 saquino0827 closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants