Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out live and pre live query pack queries #1660

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

somesylvie
Copy link
Contributor

Description

Split the query pack query into two separate ones for the live and pre-live slots

Issue

#1657

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1657 - Partially compliant

Fully compliant requirements:

  • Split up query pack query in ingestion service

Not compliant requirements:

  • Split up query pack query in TI
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

operations/template/logs.tf Show resolved Hide resolved
operations/template/logs.tf Show resolved Hide resolved
operations/template/logs.tf Show resolved Hide resolved
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
General
Improve the accuracy of log filtering by refining the query conditions

Ensure that the query does not inadvertently exclude relevant logs by using a more
specific condition in the 'where' clause.

operations/template/logs.tf [57]

-body = "AppServiceConsoleLogs | where _ResourceId !contains 'pre-live' | project JsonResult = parse_json(ResultDescription) | evaluate bag_unpack(JsonResult) | project-reorder ['@timestamp'], level, message"
+body = "AppServiceConsoleLogs | where _ResourceId !contains 'pre-live' and _ResourceId contains 'live' | project JsonResult = parse_json(ResultDescription) | evaluate bag_unpack(JsonResult) | project-reorder ['@timestamp'], level, message"
Suggestion importance[1-10]: 7

Why: The suggestion to refine the query condition in the 'where' clause is valid and can prevent the exclusion of relevant logs, which enhances the accuracy and effectiveness of the log filtering.

7

@saquino0827
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

Category Suggestion                                                                                                                                    Score
General
Improve the accuracy of log filtering by refining the query conditions
7

Although this seems like good input, our ResourceId's do not contain the text live in them. Leaving a thumbs down in hopes that PR bot learns from this

@somesylvie somesylvie merged commit 50ce96f into main Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants