Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Golden Copy Tests #1674

Draft
wants to merge 103 commits into
base: main
Choose a base branch
from
Draft

Add Golden Copy Tests #1674

wants to merge 103 commits into from

Conversation

pluckyswan
Copy link
Contributor

@pluckyswan pluckyswan commented Dec 23, 2024 •
edited
Loading

Description

Added golden copy test to RS-E2E tests. It currently is located in the same test class as the automated staging integration test. One submit workflow is responsible for sending all files including assertion and golden copy input. Then, it will fetch the output from Azure and compare them to the expected files based on the run workflow chosen.

TLDR - this utilizes the existing automated staging test submit workflow to send all files and adds a new run workflow specific to golden copy test.

Issue

#1600

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have updated the documentation accordingly

Note: You may remove items that are not applicable

jherrflexion and others added 30 commits December 16, 2024 16:56
@jherrflexion
WIP Initial setup
07b96d1
@pluckyswan
add notes for later and initial setup/cleanup
2d14e9a
@jherrflexion @somesylvie @saquino0827
Added basic compare
f8afd54 
Co-Authored-By: Sylvie <38440028+somesylvie@users.noreply.github.com>
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
@jherrflexion @saquino0827 @pluckyswan
Testing workflow dispatch
dad2cd3 
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
@jherrflexion @saquino0827 @pluckyswan
Aded Golden tests to gradle
1d8877c 
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
@jherrflexion @saquino0827 @pluckyswan
Adding Golden tests to Workflows
9b81688 
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
@jherrflexion @saquino0827 @pluckyswan
Added fetch parameter
d4867f7 
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
@jherrflexion @saquino0827 @pluckyswan
Removed comments
87dbc14 
Co-Authored-By: Samuel Aquino <saquino@flexion.us>
Co-Authored-By: Bella L. Quintero <96704946+pluckyswan@users.noreply.github.com>
@pluckyswan @saquino0827
add input files and delete unused input files
5bef9f0 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827
refactor file fetcher and implementation
83edb87 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan
refactor file fetcher calls
084387d
@pluckyswan @saquino0827
add env to workflow and rename file path
1e49731 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan
modify example files to be aligned with readme reqs
3de1187
@pluckyswan
move directory up one and fix file paths
ebe7a46
@pluckyswan
move golden copy to automated to get files after transformed
9605cc1
@pluckyswan @saquino0827
use correct syntax
f63c56c 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827
make variables strings
de61fb5 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827
add dollar sign to echo
96cae6c 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827
try fixing format
e17f1e9 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827
change syntax
0747ee8 
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827
@somesylvie @jcrichlake
remove line break at end of line in example files
bdbed53 
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jcrichlake
add double quotes to if statement
71a243d 
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jcrichlake
add golden copy versions of example files and revert to og directory …
24e5ac3 
…structure

Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jcrichlake
modify msh-10 header in example file
401c50f 
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jcrichlake
fix syntax
229af63 
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jcrichlake @jherrflexion
remove breaks from example file
9485cda 
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-authored-by: James Herr <jherr@flexion.us>
@pluckyswan @jherrflexion @jcrichlake
add example file
3c850de 
Co-authored-by: James Herr <jherr@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jherrflexion
remove comment, add quotes to variable, and create workflow file
1f0dde2 
Co-authored-by: James Herr <jherr@flexion.us>
@pluckyswan @jherrflexion
remove done
d7623ae 
Co-authored-by: James Herr <jherr@flexion.us>
@pluckyswan @jherrflexion
remove unused workflow
92c039c 
Co-authored-by: James Herr <jherr@flexion.us>
@pluckyswan pluckyswan marked this pull request as ready for review January 8, 2025 22:40
pluckyswan and others added 20 commits January 9, 2025 13:40
@pluckyswan @saquino0827 @jcrichlake
remove env variable, pass parameter to fetchFiles, add filePath enum,…
5bbcb57 
… update tests

Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan @jcrichlake @saquino0827
remove references of deleted env var
9a4eb00 
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
@pluckyswan @saquino0827 @jcrichlake
add draft of deleting outdated folders on rerun
7ae9e0c 
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: jcrichlake <145698165+jcrichlake@users.noreply.github.com>
@pluckyswan
Merge branch 'main' into golden-tests
e499659
@pluckyswan @saquino0827
@basiliskus @somesylvie
uncomment code
19dc37b 
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @saquino0827
@somesylvie @basiliskus
rename assertion related references to be assertion instead of automated
3db4f37 
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
@pluckyswan @basiliskus
@saquino0827 @somesylvie
add check to see if all files are received on submit workflow
6b6ba9c 
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @basiliskus
@saquino0827 @somesylvie
add step to notify slack on failure for submit workflow
6cbe53e 
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @basiliskus
@saquino0827 @somesylvie
change { to (
456d294 
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @basiliskus
@saquino0827 @somesylvie
exit workflow once all files have been attempted to send
edca887 
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @basiliskus
@saquino0827 @somesylvie
fix if statement syntax
ad17fa0 
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @basiliskus
@saquino0827 @somesylvie
fix if statement syntax
7040fe1 
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@pluckyswan @saquino0827 @somesylvie
fix if statement syntax
10cfe66 
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: Sylvie <sschuresko@flexion.us>
@jcrichlake
Fixing bash scripts
c754061
@jcrichlake
Fixing echo statement
5aee5e8
@pluckyswan
echo response
b4fb22d
@pluckyswan
add more echo
36a56b1
@pluckyswan
add logging for deletion method
b205243
@pluckyswan
modify deleteOldBlobs method to iterate through folder instead
e7b1b64
@pluckyswan
add if statement to differentiate between fresh and old blobs by 7 mins
36d5d51
@pluckyswan pluckyswan marked this pull request as draft January 10, 2025 23:13
pluckyswan and others added 5 commits January 13, 2025 13:41
@pluckyswan
revert previous commit
9a0480f
@pluckyswan
Merge branch 'main' into golden-tests
d119945
@pluckyswan
add logging
8b3b5b7
@pluckyswan
modify regex for submiting specific folders
3723409
@pluckyswan @somesylvie
@saquino0827 @jherrflexion @basiliskus
modify isInDateFolder method to include added folders (goldencopy/ass…
0a66321 
…ertion)

Co-authored-by: Sylvie <sschuresko@flexion.us>
Co-authored-by: saquino0827 <saquino@flexion.us>
Co-authored-by: James Herr <jherr@flexion.us>
Co-authored-by: basiliskus <541149+basiliskus@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrichlake jcrichlake jcrichlake left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@saquino0827 saquino0827 saquino0827 left review comments

@basiliskus basiliskus basiliskus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pluckyswan @basiliskus @saquino0827 @jcrichlake @jherrflexion