Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and examples for PD1-4 #1677

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

jorg3lopez
Copy link
Contributor

@jorg3lopez jorg3lopez commented Dec 27, 2024

Description

This PR is a companion to ReportStream PR 17019, which implemented the required mapping changes required to support PD1-4.

This PR:

  • Adds 2 example Ochsner OML files and related translated/transformed outputs
  • Adds a RS e2e test to ensure PD1-4 is preserved

Issue

#1620

Checklist

  • I have added tests to cover my changes

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@jbiskie jbiskie changed the title Story/1620/add pd1 mappings 4 oml 1620 - add tests and examples for PD1-4 Jan 14, 2025
@jbiskie jbiskie marked this pull request as ready for review January 14, 2025 22:00
@jbiskie jbiskie changed the title 1620 - add tests and examples for PD1-4 Add tests and examples for PD1-4 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants