DoD for OBX Segment for outbound OML #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added initially supported fields - added provenance update
sfradkin
approved these changes
Sep 8, 2023
- removed fields that were not required - added fields that are being converted - updated provenance entry
- added fields that are being converted to HL7 - removed unnecessary field flag - updated provenance
basiliskus
reviewed
Sep 15, 2023
There was a problem hiding this comment.
I left a few comments/questions. I thought we were supposed to add the names for each field exactly as they are in the documentation, but seeing your PR it seems I had the wrong assumption. Do we we need to describe the fields in plain language or do we need to document the names matching the HL7 guideline?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated required OBX Segment fields for Implementation Guide
Issue #495
Checklist