Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

613: RS Token Cache Improvement #614

Merged
merged 10 commits into from
Oct 27, 2023
Merged

613: RS Token Cache Improvement #614

merged 10 commits into from
Oct 27, 2023

Conversation

halprin
Copy link
Member

@halprin halprin commented Oct 25, 2023

RS Token Cache Improvement

We had a homebrew caching mechanism for caching the RS token when we login. This PR migrates to using the our Caching pattern. This also will be more performant because we'll do less call to a locking method.

Issue

#613.

Checklist

  • I have added tests to cover my changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@jorg3lopez jorg3lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job!

@halprin halprin merged commit d6429cd into main Oct 27, 2023
15 checks passed
@halprin halprin deleted the rs-token-cache-improvement branch October 27, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants