Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Sort By Distance tool #145

Merged
merged 12 commits into from
Aug 2, 2024
Merged

added Sort By Distance tool #145

merged 12 commits into from
Aug 2, 2024

Conversation

benjaminbeer256
Copy link
Contributor

used some methods from the GzipUtilites on the gzip support branch

I'm not sure what the algorithm is supposed to do though
and fixed CLI file
Need to take strand direction into account, and change to upstream-downstream
and changed 'left' and 'right' to upstream and downstream
along with window interface and logging
@benjaminbeer256 benjaminbeer256 requested a review from owlang October 3, 2023 16:33
owlang added 5 commits June 22, 2024 20:29
rename tool to be more precise
add javadocs in standard format with other tools (see dev branch)
clean up trailing whitespace
SortByRefCLI
- strip out filename extension restrictions
- change validation to allow for positive and negative up/downstream bounds and add relational check
- clarify up/downstream bounds flag documenation language
- rename default filename to have "DistSort" suffix
- reorganize method signature to put printstream object last
SortByRef
- redo implementation to use two large maps instead of parallel sort index array
- redo validation logic for identifying closer peak
- store search range restriction values such that null indicates no restriction
- remove negative/positive-based validation of upstream/downstream restrictions
- reorganize method signature to put printstream object last
SortByRefOutput
- rewrite output filepath construction to use ExtensionFileFilter
- add missing stop timestamp on log item
- rename default filename to have "DistSort" suffix
- reorganize method signature to put printstream object last
- comment and clean whitespace
SortByRefWindow
- restructure option parsing and validation (Task class)
  - change validation to allow for positive and negative up/downstream bounds and add relational check
  - make greater use of Exception-based error pop ups
- rename execution language to "Sort" rather than "Align" based
- reduce scope of variables that don't need large scope (e.g. moved UPSTREAM from class attribute to initialize within Task.doInBackground())
- reorganize options into subpanel
- reformat components to leverage "enabled" features for formatting, etc.
- separate up and downstream search restrictions
- comment and clean whitespace
@owlang
Copy link
Collaborator

owlang commented Aug 2, 2024

merge in new tool from #35

@owlang owlang changed the title added Sort By Reference tool added Sort By Distance tool Aug 2, 2024
@owlang owlang merged commit e02d5f4 into dev Aug 2, 2024
6 checks passed
@owlang owlang deleted the Sort-BED/GFF-by-distance branch August 2, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants