-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Sort By Distance tool #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what the algorithm is supposed to do though
and fixed CLI file
Need to take strand direction into account, and change to upstream-downstream
and changed 'left' and 'right' to upstream and downstream
along with window interface and logging
rename tool to be more precise
add javadocs in standard format with other tools (see dev branch) clean up trailing whitespace
SortByRefCLI - strip out filename extension restrictions - change validation to allow for positive and negative up/downstream bounds and add relational check - clarify up/downstream bounds flag documenation language - rename default filename to have "DistSort" suffix - reorganize method signature to put printstream object last SortByRef - redo implementation to use two large maps instead of parallel sort index array - redo validation logic for identifying closer peak - store search range restriction values such that null indicates no restriction - remove negative/positive-based validation of upstream/downstream restrictions - reorganize method signature to put printstream object last SortByRefOutput - rewrite output filepath construction to use ExtensionFileFilter - add missing stop timestamp on log item - rename default filename to have "DistSort" suffix - reorganize method signature to put printstream object last - comment and clean whitespace SortByRefWindow - restructure option parsing and validation (Task class) - change validation to allow for positive and negative up/downstream bounds and add relational check - make greater use of Exception-based error pop ups - rename execution language to "Sort" rather than "Align" based - reduce scope of variables that don't need large scope (e.g. moved UPSTREAM from class attribute to initialize within Task.doInBackground()) - reorganize options into subpanel - reformat components to leverage "enabled" features for formatting, etc. - separate up and downstream search restrictions - comment and clean whitespace
merge in new tool from #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used some methods from the GzipUtilites on the gzip support branch