-
Notifications
You must be signed in to change notification settings - Fork 6
Wrapped priority Picard tools (#122) and added program record to Filter PIP-seq output (#144) #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjaminbeer256
wants to merge
12
commits into
main
Choose a base branch
from
new-picard-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matched this branch with changes made to the dev branch when Erik-Branch was merged. This will allow a simple merge in the future as this branch is basically a fork of dev now. Added new Picard tool DownsampleSam. The tool is in the DownsampleSamFile class and its supporting window class is called DownsampleSamFileWindow Added scroll functionality to the BAM Manipulation window in allow the user to select DownsampleSam
#122 Added two classes. ValidateSamWrapper and ValidateSamWindow. The ValidateSam tool allows for customization of the validation mode, maximum output in verbose mode, whether to generate an index or not, and output destination. Currently outputs a html file. Minor bug fixing related to DownsampleSam. The program now works as intended. Reworded the javadocs. Still unsure if those javadocs are perfect.
#122 Removed the dashes from the JavaDocs in the Wrapper classes for ValidateSam and DownsampleSam. Added a short JavaDocs that references the Wrapper in the Window classes. Also, reworked the Max Output feature in ValidateSam a slight bit so it has 100 (default) in the text box to show the user what that default value is.
#122 Added two new tools. SamFormatConverter converts a SAM file to a BAM file or vice versa. SamtoFastq converts a BAM file to a FASTQ file. It has two features both of which are experiencing errors causing no output. However the default configuration runs fine. Did some minor code cleanup on ValidateSam as well. Along with an additial condition being handled in DownsampleSam. Before, when a user entered a desired maximum number of reads to be outputted that is larger than the total number of reads, the program would default to 0.5 probability without alerting the user. A JOptionPane now tells the user this fact. Also, added the option to load a SAM file instead of a BAM file for DownsampleSam and ValidateSam.
Added NormalizeFasta and CollectBaseDistributionByCycle Picard tools and added the wrapper for the FilterSamReads tool. Refactored BAIIndexer to BAIIndexerWrapper and Window to match with other tools. The charting feature for CollectBaseDistributionByCycle experiences an unknown error on my end. I am unsure if this has something to do with my R install or the code itself.
#122 Created a Wrapper and Window class for the Picard tool called FilterSamReads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erik, thanks for making my job easy 👍