-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for making animations #427
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@mauricehuguenin I opened the PR. Thanks for this! I had a look... It's quite complicated? Could we simplify it? It doesn't have to be the best, Hollywood-grade type of movie. People can fine-details their figures.... But at the moment there is a lot of code that is not really animation-relevant and a person that wants to learn about how to do animation might struggle... I personally struggled a bit to read through. (I can give you more specific comments next week..) But also it's not really working. Did I break it? |
Sure, I can simplify it quiet a bit. Thanks Navid! I'll do that when I am back from annual leave (5th of August) and will update you when I have a newer and shorter version to share. |
Ideally: load a field (few snapshots are enough) and just plot using Cartopy on some projection... Then make animation. No need to include fancy bathymetry and also no need to include a lot of fine-tuning. Most important is to have documentation-explanation of what you are trying to do so that you hold the hand of the people who will be reading your tutorial in order to learn to make their own. Also avoid using user-define directories. Let the users do that... The example can just create a directory in its own directory. I changed that but perhaps I broke something along the way...? |
I converted the PR to Draft. When you think is ready click on the "Ready for review" button! |
I'm wondering if we need a new tutorial. Can we just expand the Maps tutorial to include an animation? |
I think a separate one would be better. I was thinking this morning about pros and cons of combining recipes or having a huge number. There is definitely a tradeoff. If we combine too many things into a single recipe than it takes forever to run and it gets hard to make any changes. It can also be hard to find what's in them if the description doesn't obviously cover everything. But too many recipes is maybe not great either, because it's hard to maintain a huge number (e.g. we currently have recipes that don't even run). In general I'm not sure what's best. I am definitely finding some of the longer, more complicated recipes hard to make changes to now. This animation one could be super simple, e.g. just daily SST for a simple small domain for 1 month total duration. |
We are better with a larger number of well-described, short tutorials. |
Deal! Sounds good. |
I'm closing this in favour of #452. |
on behalf of @mauricehuguenin
closes #62