Add movie tutorial with xmovie package #452
Conversation
navidcy
requested review from
adele-morrison,
dhruvbhagtani,
mauricehuguenin,
claireyung,
hrsdawson,
willaguiar and
anton-seaice
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
navidcy
changed the title
| @@ -0,0 +1,1515 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #18. ax.set_title(f"time: {str(da['time'][timestamp].values)}")
Could get rid of a bunch of zeros in the title? e.g.
ax.set_title(f"time: {str(da['time'][timestamp].values)[:-19]}")
Though better if there was a nicer way to do that than arbitrary indexing.
Reply via ReviewNB
There was a problem hiding this comment.
True, I didn't bother I admit. I thought it goes beyond the aim of the tutorial. I don't want to hardcode [:-19] which might work for this case but not for something else....
There was a problem hiding this comment.
I'll add an issue for this and we can tackle in the future.
| @@ -0,0 +1,1515 @@ | |||
| { | |||
There was a problem hiding this comment.
What about adding overwrite_existing=True ? Otherwise this will throw an error if the file already exists and the testing might have trouble?
Reply via ReviewNB
There was a problem hiding this comment.
I was thinking about it, but also I thought it's better that the default does not have the overwrite_existing=True so that people don't accidentally delete something they didn't want to. We can add it later if this creates issue for tests?
A tutorial for how to create movies using xmovie package.
Supersedes #427