fix(importer): import correct mgm_id in changelog_rule#4416
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts changelog mgm_id handling during imports (notably for FortiManager sub-management scenarios) so changelog entries align with the management context used for imported rules/objects/services/users, and includes a DB upgrade step to correct existing inconsistent rows.
Changes:
- Use
current_mgm_id(instead ofmgm_id) when building changelog insert objects in the importer. - Add a DB upgrade script section to reconcile
changelog_*.mgm_idvalues with their referenced entities’mgm_id. - Add a unit test asserting
write_changelog_rules()usescurrent_mgm_id.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| roles/importer/files/importer/test/test_fwconfig_import_rule.py | Adds a test ensuring rule changelog writes use current_mgm_id. |
| roles/importer/files/importer/fwo_log.py | Switches changelog object creation to use current_mgm_id. |
| roles/database/files/upgrade/9.0.15.sql | Adds data-fix updates to align changelog table mgm_id with referenced entity mgm_id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tpurschke
approved these changes
Mar 23, 2026
Contributor
tpurschke
left a comment
tpurschke
left a comment
There was a problem hiding this comment.
Reviewing as substitution for Chris (absence)
Contributor
|
Please Update branch |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4394