Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modularised cpdAssign #68

Draft
wants to merge 20 commits into
base: ustar_cp_refactor_main
Choose a base branch
from

Conversation

j-emberton
Copy link
Member

No description provided.

@j-emberton j-emberton added this to the Modularised all MATLAB code milestone Dec 9, 2024
@j-emberton j-emberton self-assigned this Dec 9, 2024
@j-emberton
Copy link
Member Author

@dorchard @isaacaka would appreciate it if you think there's any more sensible moves to modularise this function further. Its a bit of a mess of repeated mutation and early exit.

@dorchard
Copy link
Member

Delayed waiting on the more unified cross-language testing approach.

@dorchard
Copy link
Member

dorchard commented Feb 13, 2025

Note the tests use jsondecode which we may want to avoid going through into the Python.
Therefore in conftest.py we need to drop that keyword in the test engine, e.g.,

                if 'jsondecode' in kwargs:
                    kwargs.pop('jsondecode')

in the newfunc function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants