Feat: Polkadot v1.10 to v1.12 upgrade #452
Conversation
…nto feat/polkadot-v1.12.0-upgrade # Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # runtime/cere-dev/src/lib.rs # runtime/cere/src/lib.rs
| @@ -6,6 +6,7 @@ use sc_client_api::{ | |||
| AuxStore, Backend as BackendT, BlockchainEvents, KeysIter, MerkleValue, PairsIter, | |||
| UsageProvider, | |||
| }; | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
@Aideepakchaudhary Are we going to handle this in future PRs? If yes, please add a todo with version number
There was a problem hiding this comment.
we have addressed these deprecates here in this PR: #456
| @@ -18,6 +19,7 @@ use sp_runtime::{ | |||
| use sp_storage::{ChildInfo, StorageData, StorageKey}; | |||
|
|
|||
| pub type FullBackend = sc_service::TFullBackend<Block>; | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
@Aideepakchaudhary If we are handling this in future PRs, please add a todo with version number
There was a problem hiding this comment.
same for this
| @@ -30,6 +30,7 @@ pub use cere_client::{ | |||
| }; | |||
| pub use chain_spec::{CereChainSpec, CereDevChainSpec}; | |||
| pub use node_primitives::{Block, BlockNumber}; | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
@Aideepakchaudhary If we are handling this in future PRs, please add a todo with version number
There was a problem hiding this comment.
same for this
There was a problem hiding this comment.
@Aideepakchaudhary paritytech/polkadot-sdk#4177 was also merged in 1.12.0. Can you include corresponding changes?
Please take a look https://github.com/paritytech/polkadot-sdk/blob/polkadot-v1.12.0/templates/solochain/runtime/build.rs for example.
@ayushmishra2005 , we are addressing these changes here in this PR: #456 |
|
@Aideepakchaudhary Please tag corresponding polkadot upgrade PR. For example #456 instead of #460 |
Description
This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release
v1.10.0to1.12.0Notes
Relevant upgrade's notes and comments.
Migration of pallet-staking and pallet-contract
Possible Breaking changes:
sc-serviceparitytech/polkadot-sdk#4457]: sc-service: export all public functionspallet_staking,pallet_session, andpallet_balancesparitytech/polkadot-sdk#4346]: Allow for 0 existential deposit in benchmarks for pallet_staking, pallet_session, and pallet_balancesDepositedandWithdrawnparitytech/polkadot-sdk#4312]: Add Deposited/Withdrawn events for pallet-assetsKindly refer to the official Polkadot release report for further details: Polkadot v1.12.0
Process
spec_verfor bothtestnetandmainnetRuntime.TBDCodebase Upgrade Acceptance Criteria
cargo checkpassescargo testpassescargo buildon-- releaseprofile correctly buildstry-runtimeandruntime-benchmarksfeatures compileblock-productionconfig file generates blocks.Runtime & Node Upgrade Acceptance Criteria
Runtime upgrade works on Zombienet
Node upgrade works on Zombienet
Runtime upgrade works on Chopsticks
Try-runtime passes with no pending migrations
<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->
Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->
Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
on_initializeon_finalizeChecklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_versionhas been incremented.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_versionhas been incremented.devhas been created.staginghas been created.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->