3D Tiles bounding volume improvements #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
reviewed
Nov 15, 2023
Comment on lines
69
to
70
| * If the transformation has non-uniform scale, the bounding sphere's radius | ||
| * is scaled by the scale of the transformation's axis with the largest scale. |
There was a problem hiding this comment.
This reads a bit more clearly to me?
Suggested change
| * If the transformation has non-uniform scale, the bounding sphere's radius | |
| * is scaled by the scale of the transformation's axis with the largest scale. | |
| * If the transformation has non-uniform scale, the bounding sphere's radius | |
| * is scaled by the largest scale value among the transformation's axes. |
| * | ||
| * @param boundingVolume The bounding volume from which to get the region. | ||
| * @return The region, or `std::nullopt` if the bounding volume does not | ||
| * define a region. The box is defined in geographic coordinates. |
There was a problem hiding this comment.
Suggested change
| * define a region. The box is defined in geographic coordinates. | |
| * define a region. The region is defined in geographic coordinates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #747 so merge that first.
Fixes #647
TileBoundingVolumesclass toCesium3DTilesContent, making it easier to create the rich bounding volume types inCesiumGeometryandCesiumGeospatialfrom the simplestd::vectorrepresentations inCesium3DTilestransformmethod toCesiumGeometry::BoundingSphere.toSphere,fromSphere, andfromAxisAlignedmethods toCesiumGeometry::OrientedBoundingBox.TileTransformclass toCesium3DTilesContent, making it easier to create aglm::dmat4from thetransformproperty of aCesium3DTiles::Tile.