First pass at performance testing #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derived from FLoadAllMapsInEditorTest in EditorAutomationTests.cpp
Fix raster imagery not showing. Name actors for convenience
…tiles loaded (still WIP)
And don't run performance tests on CI
|
Thanks for the pull request @csciguy8!
Reviewers, don't forget to make sure that:
|
This was referenced Aug 29, 2023
Merged
When PIE ends, it seems to clear all tiles. Before we froze the state of what the test loaded, which was useful. But it's not all that useful to just see nothing when the test ends. Let it stream it all back in. Also, move play session param to context so it can be configured if needed
Melbourne 'after' test is temporarily commented out
Useful when debugging
kring
reviewed
Oct 16, 2023
|
Thanks for the the review @kring . Ready for another look. |
kring
reviewed
Oct 16, 2023
| @@ -2077,25 +2077,25 @@ void ACesium3DTileset::Tick(float DeltaTime) { | |||
| CreateViewStateFromViewParameters(camera, unrealWorldToCesiumTileset)); | |||
| } | |||
|
|
|||
| Cesium3DTilesSelection::ViewUpdateResult result; | |||
| const Cesium3DTilesSelection::ViewUpdateResult* result; | |||
There was a problem hiding this comment.
Nitpick, but it would be better to name this pResult. https://github.com/CesiumGS/cesium-native/blob/main/doc/style-guide.md#-naming
Sometimes we use Unreal's naming conventions instead (we should be more consistent about this), in which case the proper name would be Result.
I'll make this change and then merge this in order to avoid another cycle just for trivial changes.
Add suite of performance tests for Google 3D Photorealistic tiles
|
Thanks @csciguy8! 🎉 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial performance testing for Unreal. Also adds profiling guides for MSVS CPU usage and Unreal Insights.
Similar to unit tests, performance tests can be run using the Unreal Automation System. The goal is to create repeatable scenarios used for assessing various performance criteria. They are programmatically generated, can pass / fail based on whatever criteria we chose, and can eventually run on continuous integration (CI).
This PR adds a 2 simple load tests, each using different locations, and will measure the time it takes for all tilesets to load fully. Results are output to the console (log). If you are running from the editor when the test has finished, you will see the scene that was generated and all tiles frozen in place.
Comments welcome. This PR was intentionally left simple to serve as discussion for future work in this area.
Relates to cesium-native issue 698