Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark #394

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Benchmark #394

merged 2 commits into from
Feb 10, 2025

Conversation

francois141
Copy link
Collaborator

No description provided.

@francois141 francois141 requested a review from CharlyCst January 28, 2025 16:51
@francois141 francois141 force-pushed the fine-grained-counter-benchmark branch 4 times, most recently from 8e59582 to ce182df Compare January 29, 2025 14:24
Copy link
Owner

@CharlyCst CharlyCst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good, but I am not convinced we need a new benchmark backend, I think the "counter" backend is enough, but we just need to make it per-core (as you did with the new file, so we could override the old one). The more we have the more maintenance is needed, so let's keep only what we need.

Is "per_code" a typo?

@@ -0,0 +1,25 @@
# A simple configuration to run on StarFive VisionFive 2 platform in release mode
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have multiple VisionFive 2 configs, we need to clarify what this one does and why it is different from the others. It is not obvious from just reading the file for new people coming to the project.

@CharlyCst
Copy link
Owner

We also need better commit description: "This commit introduces a new benchmark used to debug and understand how the system behaves" does not explain how the new benchmark infrastructure is different and why we needed it. It only states what is obvious from the diff: we have more code now.
Overall commit descriptions need to explain why the project evolved the way it evolved.

@francois141
Copy link
Collaborator Author

To clarify: it counts per mcause trap reason, not per core.

@francois141 francois141 requested a review from CharlyCst February 3, 2025 18:12
@francois141 francois141 force-pushed the fine-grained-counter-benchmark branch 4 times, most recently from c01390e to d439255 Compare February 10, 2025 13:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This commit introduces a new benchmark which tracks the number of interrupts for each Mcause exceptions. This benchmark is used only for debugging and doesn't return the values to the kernel when there is an ecall request for measurements. Instead, it simply prints then to UART such that we can analyse the output and have a clearer understanding of the behavior in the system.
Currently, we can only delegate the cycle register in Miralis when delegating the perf counter. This commit adds the two other registers and delegates the perf counters on the VisionFive2 board in the release build.
@francois141 francois141 force-pushed the fine-grained-counter-benchmark branch from d439255 to d7ebb27 Compare February 10, 2025 13:43
Copy link
Owner

@CharlyCst CharlyCst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good :)

@CharlyCst CharlyCst merged commit 32b8e2b into main Feb 10, 2025
1 check passed
@CharlyCst CharlyCst deleted the fine-grained-counter-benchmark branch February 10, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants