reduce 3 trusts requirement #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -357,7 +357,7 @@ | |||
|
|
|||
| CIRCLES_HUB_ADDRESS = env("HUB_ADDRESS", default="0x" + "0" * 39 + "6") | |||
| GRAPH_NODE_ENDPOINT = env("GRAPH_NODE_ENDPOINT", default="") | |||
| MIN_TRUST_CONNECTIONS = env("MIN_TRUST_CONNECTIONS", default=3) | |||
There was a problem hiding this comment.
That's one option for changing the variable value. Another option is setting the value of MIN_TRUST_CONNECTIONS in the .env file and deploying the service with any code change but using the value en the .env file. I prefer the second option since it does not require a new service release. What do you think?
There was a problem hiding this comment.
Cool, then you need to add the variable in the helm templates in https://github.com/CirclesUBI/circles-iac/tree/main/helm/circles-infra-suite
There was a problem hiding this comment.
check here: CirclesUBI/circles-iac#143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.