Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce 3 trusts requirement #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reduce 3 trusts requirement #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@

CIRCLES_HUB_ADDRESS = env("HUB_ADDRESS", default="0x" + "0" * 39 + "6")
GRAPH_NODE_ENDPOINT = env("GRAPH_NODE_ENDPOINT", default="")
MIN_TRUST_CONNECTIONS = env("MIN_TRUST_CONNECTIONS", default=3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's one option for changing the variable value. Another option is setting the value of MIN_TRUST_CONNECTIONS in the .env file and deploying the service with any code change but using the value en the .env file. I prefer the second option since it does not require a new service release. What do you think?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full ack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, then you need to add the variable in the helm templates in https://github.com/CirclesUBI/circles-iac/tree/main/helm/circles-infra-suite

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check here: CirclesUBI/circles-iac#143

MIN_TRUST_CONNECTIONS = env("MIN_TRUST_CONNECTIONS", default=1)
SUBGRAPH_NAME = env("SUBGRAPH_NAME", default="")

# DOCKER
Expand Down