MC-1969 fixes #86
Open
MC-1969 fixes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzagorchev
requested changes
Sep 19, 2024
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativePreferenceManager.cs
Outdated
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativePreferenceManager.cs
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativePreferenceManager.cs
Outdated
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativePreferenceManager.cs
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativePreferenceManager.cs
Outdated
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/Models/UnityNativeUserEventQueue.cs
Outdated
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/Models/UnityNativeRaisedEventQueue.cs
Outdated
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativeNetworkEngine.cs
Outdated
Show resolved
Hide resolved
CleverTap/Runtime/Native/UnityNativeWrapper/UnityNativeNetworkEngine.cs
Outdated
Show resolved
Hide resolved
nzagorchev
requested changes
Oct 3, 2024
| } | ||
|
|
||
| public void SetDouble(string key, string doubleValue) |
There was a problem hiding this comment.
Set double should accept a double value
| { | ||
| return double.Parse(PlayerPrefs.GetString(GetStorageKey(key), defaultValue.ToString(CultureInfo.InvariantCulture))); | ||
| } | ||
| public void SetBool(string key, int value) |
There was a problem hiding this comment.
Set bool should use a bool value as parameter.
Add new line before method.
| @@ -1,6 +1,6 @@ | |||
| #if (!UNITY_IOS && !UNITY_ANDROID) || UNITY_EDITOR | |||
| namespace CleverTapSDK.Native { | |||
| internal class UnityNativeValidationResult { | |||
| public class UnityNativeValidationResult { | |||
| @@ -0,0 +1,130 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using CleverTapSDK.Native; | |||
There was a problem hiding this comment.
Remove unused namespace.
| } | ||
| catch (Exception t) | ||
| { | ||
| CleverTapLogger.Log("Error handling discarded events response: " + t.StackTrace); |
There was a problem hiding this comment.
The variable 't' is still unused and the exception details not logged.
| private Coroutine timerCoroutine; | ||
|
|
||
| internal UnityNativeBaseEventQueue(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, int queueLimit = 49, int defaultTimerInterval = 1) | ||
| internal UnityNativeBaseEventQueue(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine,UnityNativeEventValidator eventValidator, int queueLimit = 49, int defaultTimerInterval = 1) |
There was a problem hiding this comment.
eventValidator is not needed since it is unused.
| internal UnityNativeEventBuilder(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine) { | ||
| private UnityNativeEventValidator _eventValidator; | ||
|
|
||
| internal UnityNativeEventBuilder(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, UnityNativeEventValidator eventValidator) { |
There was a problem hiding this comment.
eventValidator is unused, so it is not needed
| @@ -9,12 +9,12 @@ internal class UnityNativeEventQueueManager { | |||
| private readonly UnityNativeBaseEventQueue _userEventsQueue; | |||
| private readonly UnityNativeBaseEventQueue _raisedEventsQueue; | |||
|
|
|||
| internal UnityNativeEventQueueManager(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, UnityNativeDatabaseStore databaseStore) { | |||
| internal UnityNativeEventQueueManager(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, UnityNativeDatabaseStore databaseStore, UnityNativeEventValidator eventValidator) { | |||
There was a problem hiding this comment.
Why do we need an eventValidator here? It is not needed by the queues so it is not really used.
| @@ -7,7 +7,7 @@ internal class UnityNativeUserEventQueue : UnityNativeBaseEventQueue { | |||
|
|
|||
| protected override string QueueName => "USER_EVENTS"; | |||
|
|
|||
| internal UnityNativeUserEventQueue(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, int queueLimit = 49, int defaultTimerInterval = 1) : base(coreState, networkEngine, queueLimit, defaultTimerInterval) { } | |||
| internal UnityNativeUserEventQueue(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, UnityNativeEventValidator eventValidator, int queueLimit = 49, int defaultTimerInterval = 1) : base(coreState, networkEngine, eventValidator, queueLimit, defaultTimerInterval) { } | |||
There was a problem hiding this comment.
eventValidor is unused, remove it.
| @@ -8,7 +8,8 @@ internal class UnityNativeRaisedEventQueue : UnityNativeBaseEventQueue { | |||
|
|
|||
| protected override string QueueName => "RAISED_EVENTS"; | |||
|
|
|||
| internal UnityNativeRaisedEventQueue(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, int queueLimit = 49, int defaultTimerInterval = 1) : base(coreState, networkEngine, queueLimit, defaultTimerInterval) { } | |||
| internal UnityNativeRaisedEventQueue(UnityNativeCoreState coreState, UnityNativeNetworkEngine networkEngine, UnityNativeEventValidator eventValidator, int queueLimit = 49, int defaultTimerInterval = 1) : | |||
There was a problem hiding this comment.
The eventValidator seems unused here. Why do we need it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ARP
Implement discarded events handling
Added UnityCoreState in UnityNativeNetworkEngine