MC-1969 fixes #86
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using CleverTapSDK.Native; | ||
|
There was a problem hiding this comment. Remove unused namespace. |
||
| using CleverTapSDK.Utilities; | ||
|
|
||
| #if (!UNITY_IOS && !UNITY_ANDROID) || UNITY_EDITOR | ||
| namespace CleverTapSDK.Native | ||
| { | ||
| internal class UnityNativeARPResponseInterceptor : IUnityNativeResponseInterceptor | ||
| { | ||
| private readonly UnityNativeEventValidator _eventValidator; | ||
| private readonly string _accountId; | ||
| private readonly string _namespaceARPKey; | ||
| public UnityNativeARPResponseInterceptor(string accountId,string deviceId, UnityNativeEventValidator eventValidator) | ||
| { | ||
| this._accountId = accountId; | ||
| this._namespaceARPKey = string.Format(UnityNativeConstants.Network.ARP_NAMESPACE_KEY,accountId,deviceId); | ||
| _eventValidator = eventValidator; | ||
| } | ||
|
|
||
| UnityNativeResponse IUnityNativeResponseInterceptor.Intercept(UnityNativeResponse response) | ||
| { | ||
| var result = Json.Deserialize(response.Content) as Dictionary<string, object>; | ||
| try | ||
| { | ||
| if (result.ContainsKey("arp")) | ||
| if (Json.Deserialize(result["arp"].ToString()) is Dictionary<string, object> { Count: > 0 } arp) | ||
| { | ||
| //Handle Discarded events in ARP | ||
| try | ||
| { | ||
| ProcessDiscardedEventsList(arp); | ||
| } | ||
| catch (Exception t) | ||
| { | ||
| CleverTapLogger.Log("Failed to process ARP discarded events"); | ||
| } | ||
|
|
||
| HandleARPUpdate(arp); | ||
| } | ||
| } | ||
| catch (Exception exception) | ||
|
There was a problem hiding this comment. The 'exception' variable is not used. Please log the exception details. |
||
| { | ||
| CleverTapLogger.Log("Failed to process ARP"); | ||
| } | ||
|
|
||
| return response; | ||
| } | ||
|
|
||
|
|
||
| private void HandleARPUpdate(Dictionary<string, object> arp) | ||
| { | ||
| if (arp == null || arp.Count == 0 || string.IsNullOrEmpty(_namespaceARPKey)) | ||
| return; | ||
|
|
||
| UnityNativePreferenceManager preferenceManager = UnityNativePreferenceManager.GetPreferenceManager(_accountId); | ||
| Dictionary<string, object> currentARP = Json.Deserialize(preferenceManager.GetString(_namespaceARPKey, "{}")) as Dictionary<string, object>; | ||
|
|
||
| if (currentARP == null || currentARP.Count == 0) | ||
| { | ||
| preferenceManager.SetString(_namespaceARPKey, Json.Serialize(arp)); | ||
| return; | ||
| } | ||
|
|
||
| foreach (var keyValuePair in arp) | ||
| { | ||
| string key = keyValuePair.Key; | ||
| object value = keyValuePair.Value; | ||
|
|
||
| switch (value) | ||
| { | ||
| case int i: | ||
| currentARP[key] = i; | ||
| break; | ||
| case long l: | ||
| currentARP[key] = l; | ||
| break; | ||
| case float f: | ||
| currentARP[key] = f; | ||
| break; | ||
| case double d: | ||
| currentARP[key] = d; | ||
| break; | ||
| case string s: | ||
| currentARP[key] = s; | ||
| break; | ||
| case bool b: | ||
| currentARP[key] = b; | ||
| break; | ||
| default: | ||
| CleverTapLogger.Log($"ARP update for key {key} rejected (invalid data type)"); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| preferenceManager.SetString(_namespaceARPKey, Json.Serialize(currentARP)); | ||
| } | ||
|
|
||
|
|
||
| private void ProcessDiscardedEventsList(Dictionary<string, object> response) | ||
| { | ||
| if (!response.ContainsKey(UnityNativeConstants.EventMeta.DISCARDED_EVENT_JSON_KEY)) | ||
| { | ||
| CleverTapLogger.Log("ARP doesn't contain the Discarded Events key"); | ||
| return; | ||
| } | ||
|
|
||
| try | ||
| { | ||
| var discardedEventsList = new List<string>(); | ||
| // Get the discarded event JSON from the response | ||
| string discardedEventsJson = response[UnityNativeConstants.EventMeta.DISCARDED_EVENT_JSON_KEY].ToString(); | ||
| var discardedEventsArray = Json.Deserialize(discardedEventsJson) as List<string>; | ||
| if (discardedEventsArray != null) | ||
| { | ||
| discardedEventsList.AddRange(discardedEventsArray); | ||
| } | ||
| if (_eventValidator != null) | ||
| _eventValidator.SetDiscardedEvents(discardedEventsList); | ||
| else | ||
| CleverTapLogger.Log("Validator object is NULL"); | ||
| } | ||
| catch (Exception e) | ||
| { | ||
| CleverTapLogger.Log("Error parsing discarded events list" + e.StackTrace); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventValidator is unused, so it is not needed