Merged
Conversation
prooflesben
previously requested changes
Sep 27, 2025
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
Looks good to me. Are you able to unstage/take out the changes to the package-lock.json. It looks like its updates to our dependcies but when I tried to run things locally on your branch somethings weren't working. Please do show me how you updated the frontend package-lock.json in the next meeting and we can do it on a different branch to make sure it works.
aaronashby
reviewed
Sep 28, 2025
Contributor
aaronashby
left a comment
aaronashby
left a comment
There was a problem hiding this comment.
Also LGTM! For the package-lock, I got away with not staging those changes and just reverting them. Not sure if that would affect anything, but just an fyi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
#132
📝 Description
I added unit tests for each method in the auth service, mocking the appropriate Cognito methods and the calls to the database.
✔️ Verification
Running npm test in backend to see all tests passed.