984 Tidy up emojis #1282
Merged
984 Tidy up emojis #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOT done yet - react, cloud, other unused blocks
flipped the link emoji to the start on readme block to line up with everything else - we won't try to pass an emoji from the readmes
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-curriculum canceled.
|
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
and rm youtube emoji from screenreader title
I'm wrong, we do want them, for recall and review
illicitonion
approved these changes
Jan 2, 2025
❌ Deploy Preview for cyf-itd failed. Why did it fail? →
|
1 similar comment
❌ Deploy Preview for cyf-itd failed. Why did it fail? →
|
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
moved all the emojis to the emoji param from title
showed emoji on title on block
decided against table of contents
Common Content?
all blocks, basically
Common Theme?
#1282
edited local.html to show emoji in title
edited readme.html to move link emoji to before text to match
https://github.com/CodeYourFuture/curriculum/pull/1282/files?file-filters%5B%5D=.html&show-deleted-files=true&show-viewed-files=true