T0024 - Automatic reminder for invalid partners

[Gordack]

A scheduled action should be created, similar to :

After test with MailHog, the following output is obtained :

[ecino]

One small remark and another general question : Could we simply automatically archive the found contacts (and still send the notification email to SDS)? Then in the email we could simply write: "Those following contacts were found and automatically archived". That means writing {"archive": True} on them.

[Gordack]

One small remark and another general question : Could we simply automatically archive the found contacts (and still send the notification email to SDS)? Then in the email we could simply write: "Those following contacts were found and automatically archived". That means writing {"archive": True} on them.

When I discussed that with Sarah, she was not so happy about the idea of automating the archive part, because she was scared that Odoo would archive people that should not be archived. Therefore, when we discussed that with Andre, we choose to not automatically archive first, in order to let SDS check that the people we propose to archive are the good ones. But yes, if SDS is happy with how the criteria are set, it would be better to archive the people that need to be archived automatically.

[ecino]

Waiting Sarah's feedback in order to know whether we should directly archive those contacts or not.

[nlachat-compassion]

Waiting Sarah's feedback in order to know whether we should directly archive those contacts or not.

@ecino I'm taking over this task. So in the end, we should not automatically archive the invalid partners, correct? Only send an email reminder with the list of potentially invalid partners?

[ecino]

@nlachat-compassion exactly

[nlachat-compassion]

What I did until now:

• Add xml definition for the cron job which sends the reminder (configured to send once a week)
• Add a link to the task T0024 as a reference for the criteria which define a partner as invalid in the email reminder
• Pass the list of invalid partners through the context in the email template in order to avoid computing it twice. This requires a modification to another repo: T0024 - Allow passing arbitrary data to email template through context compassion-modules#1979 , which should be merged before this one.

@ecino what do you think about my proposed implementation?

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud