feat: Add lint and prettier check in workflow #955
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1d3fe0e in 19 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/lint_js.yml:34
- Draft comment:
continue-on-error: falseis unnecessary as it is the default behavior. Consider removing it for cleaner code. This applies to line 38 as well. - Reason this comment was not posted:
Confidence changes required:20%
The workflow is well-structured, but there's a minor inconsistency in the use ofcontinue-on-error.
Workflow ID: wflow_a3HzDM34N2NgmT42
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2c000e5 in 1 minute and 11 seconds
More details
- Looked at
4679lines of code in36files - Skipped
2files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. js/package.json:16
- Draft comment:
Consider removing the--max-warnings=177option from the ESLint script to ensure all warnings are addressed rather than ignored. - Reason this comment was not posted:
Confidence changes required:50%
The ESLint command in the package.json file includes a specific number of maximum warnings (177). This seems arbitrary and might not be suitable for all cases. It's better to address warnings rather than setting a high threshold.
2. js/src/sdk/utils.ts:29
- Draft comment:
The function nameconverReqParamForActionExecutionseems to have a typo. Consider renaming it toconvertReqParamForActionExecution. - Reason this comment was not posted:
Comment was on unchanged code.
3. js/src/sdk/base.toolset.ts:13
- Draft comment:
The functionconverReqParamForActionExecutionis used here. Ensure the function name is corrected toconvertReqParamForActionExecutionto match the intended naming convention. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_sGvrTMxbdgjn0BZ3
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| import tseslint from "typescript-eslint"; | ||
|
|
||
|
|
||
| /** @type {import('eslint').Linter.Config[]} */ |
There was a problem hiding this comment.
Consider specifying a parser in the ESLint configuration, such as @typescript-eslint/parser, to ensure proper linting of TypeScript files.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 21d3f78 in 31 seconds
More details
- Looked at
264lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/cli/index.ts:8
- Draft comment:
The import statement for './add' is unnecessary since 'add.ts' was removed. Please remove this import. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_35cwVgwV4sWBFJVt
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 91668f2 in 17 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/lint_js.yml:38
- Draft comment:
Add a newline at the end of the file for better compatibility with version control systems. - Reason this comment was not posted:
Confidence changes required:50%
The YAML file lacks a newline at the end, which is a best practice for version control systems.
Workflow ID: wflow_Fd7dq9infTs0LrnG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b016720 in 20 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/lint_js.yml:33
- Draft comment:
Ensure that thepackage.jsonscripts section has aneslintscript defined. If it was previouslylint, update it toeslintto match this change. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_7IlgrYxEl0qRzWs9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5c9135d in 19 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/package.json:16
- Draft comment:
Consider reviewing the increase in--max-warningsfrom 177 to 193. Ensure this change is intentional and not overlooking new warnings. - Reason this comment was not posted:
Confidence changes required:50%
The change in max-warnings from 177 to 193 in the eslint script might indicate an increase in allowed warnings, which could be a temporary measure. It's important to ensure that this is intentional and not a result of overlooking new warnings.
Workflow ID: wflow_m28KFcoE6vrpjnBv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6345851 in 19 seconds
More details
- Looked at
38lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/lint_js.yml:34
- Draft comment:
Add a newline at the end of the file for better compatibility with Unix-based systems. - Reason this comment was not posted:
Confidence changes required:50%
The workflow file is missing a newline at the end, which is a common best practice for text files.
Workflow ID: wflow_odKwHDXcboro7YuJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5c21131 in 37 seconds
More details
- Looked at
43lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/lint_js.yml:28
- Draft comment:
The node version '22' is not valid. Consider using 'lts/*' to ensure compatibility with the latest LTS version. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about a change made in the diff, specifically the node version. The suggestion to use 'lts/*' is a valid point for ensuring compatibility with the latest LTS version. However, the comment states '22' is not valid, which might not be accurate if '22' is a valid version. The comment is not speculative and directly addresses a change made in the diff.
I might be missing the context of whether '22' is a valid Node.js version. If '22' is indeed a valid version, the comment's claim of it being invalid is incorrect.
I should verify if '22' is a valid Node.js version. If it is, the comment should be deleted as it incorrectly states that '22' is not valid.
Check if '22' is a valid Node.js version. If it is, delete the comment as it incorrectly states that '22' is not valid.
Workflow ID: wflow_KPbS2Tk5lDB3pCiT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 633f47f in 1 minute and 6 seconds
More details
- Looked at
7804lines of code in43files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/sdk/utils/errors/src/formatter.ts:81
- Draft comment:
Thedefaultcase in thegetAPIErrorDetailsfunction is redundant as it performs the same operations as the specific cases above it. Consider refactoring to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The code ingetAPIErrorDetailsfunction is handling different error codes and returning appropriate error details. However, thedefaultcase is redundant because it is essentially doing the same thing as the specific cases above it. This can be refactored to avoid redundancy.
Workflow ID: wflow_CdoLkHfSZfRl8XEQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 06f7888 in 1 minute and 19 seconds
More details
- Looked at
101lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. js/src/cli/apps.ts:85
- Draft comment:
Consider rethrowing the error after logging it to avoid silent failures. - Reason this comment was not posted:
Comment was on unchanged code.
2. js/src/cli/apps.ts:108
- Draft comment:
Consider rethrowing the error after logging it to avoid silent failures. - Reason this comment was not posted:
Marked as duplicate.
3. js/src/sdk/models/connectedAccounts.ts:64
- Draft comment:
Consider renamingredirectUritoredirectUrlin the constructor for consistency. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_qANAfSkZtRoL08nl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d7e7e0f in 1 minute and 23 seconds
More details
- Looked at
68lines of code in5files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. js/src/sdk/utils/pusher.ts:123
- Draft comment:
Consider usingconstinstead ofvarfor variable declaration to ensure block scoping and prevent potential hoisting issues.
const channel = PusherUtils.pusherClient.subscribe(
- Reason this comment was not posted:
Comment looked like it was already resolved.
2. js/src/sdk/models/Entity.spec.ts:8
- Draft comment:
Consider usingconstinstead ofvarfor variable declaration to ensure block scoping and prevent potential hoisting issues. This issue is also present inworkspace.ts. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_dqo1TcskLouxpC1Q
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1ac2fd1 in 1 minute and 1 seconds
More details
- Looked at
60lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_5OBKHR3XFIvwPr7b
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Add GitHub Actions workflow for linting and formatting JavaScript and TypeScript files using ESLint and Prettier, with configuration updates and file cleanup.
lint_js.ymlworkflow to run ESLint and Prettier on.jsand.tsfiles on push and pull request events.eslint.config.mjswith rules for TypeScript and JavaScript linting..prettierrcwith formatting rules.eslint,prettier, andprettier:check.js/src/cli/add.tsas it is no longer needed.This description was created by
for 1ac2fd1. It will automatically update as commits are pushed.