-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add lint and prettier check in workflow #955
Merged
Merged
Changes from 36 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ba8a2fc
ran prettier on the code base
plxity 2c000e5
added github action to verify linting and formatting
plxity 1d3fe0e
fixed config
plxity 21d3f78
fixed eslint error
plxity 91668f2
fixed folder directory
plxity b016720
fixed script
plxity 5c9135d
updated warning limit
plxity 6345851
fixed script
plxity 5c21131
fixed script
plxity ab41179
fixed script
plxity cf14c9c
fixed script
plxity 4bcfbf7
fixed script
plxity 363f093
fixed script
plxity 7e5cbec
fixed script
plxity 571ff28
updated warning limit
plxity e1a47c0
fixed script
plxity 3729079
added prettier
plxity ea16312
fixed script
plxity 41c60c7
fixed script
plxity a328121
Merge branch 'master' into ENG-2785
plxity a274541
Merge branch 'master' into ENG-2785
plxity dc7f18f
feat: staged changes
himanshu-dixit 615d834
feat: remove package lock and add eslint
himanshu-dixit d895ee4
Merge branch 'master' of github.com:ComposioHQ/composio into ft-ENG-2…
himanshu-dixit bfcff89
feat: pnpm lock
himanshu-dixit 63a74a1
feat: changes
himanshu-dixit 177cd45
feat: package change
himanshu-dixit 929d7dc
feat: change to push
himanshu-dixit aa0db07
feat: revert lint
himanshu-dixit 7629399
feat: disable no console in cli
himanshu-dixit 3bf800c
feat: remove any
himanshu-dixit d9a0855
feat: add setup cli
himanshu-dixit bfabe4e
feat: rollup
himanshu-dixit 70fba4b
fix: add support for main
himanshu-dixit 633f47f
run prettier on changed file
plxity 06f7888
feat: connectedAccount fix
himanshu-dixit e3a0908
feat: logger
himanshu-dixit d7e7e0f
fix: eslint issues
himanshu-dixit 1ac2fd1
feat: prettier
himanshu-dixit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: Check Linting and Formatting (JS) | ||
|
||
on: | ||
push: | ||
paths: | ||
- '**/*.js' | ||
- '**/*.ts' | ||
pull_request: | ||
paths: | ||
- '**/*.js' | ||
- '**/*.ts' | ||
|
||
jobs: | ||
lint-and-prettify: | ||
runs-on: ubuntu-latest | ||
|
||
defaults: | ||
run: | ||
working-directory: js | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20' | ||
|
||
- name: Install pnpm | ||
run: npm install -g pnpm | ||
|
||
- name: Install packages in js folder | ||
run: pnpm install --frozen-lockfile | ||
|
||
- name: Run ESLint | ||
run: pnpm run eslint | ||
continue-on-error: false | ||
|
||
- name: Run Prettier | ||
run: pnpm run prettier:check | ||
continue-on-error: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
|
||
{ | ||
"arrowParens": "always", | ||
"bracketSpacing": true, | ||
"endOfLine": "lf", | ||
"htmlWhitespaceSensitivity": "css", | ||
"insertPragma": false, | ||
"singleAttributePerLine": false, | ||
"bracketSameLine": false, | ||
"jsxBracketSameLine": false, | ||
"jsxSingleQuote": false, | ||
"printWidth": 80, | ||
"proseWrap": "preserve", | ||
"quoteProps": "as-needed", | ||
"requirePragma": false, | ||
"semi": true, | ||
"singleQuote": false, | ||
"tabWidth": 2, | ||
"trailingComma": "es5", | ||
"useTabs": false, | ||
"embeddedLanguageFormatting": "auto", | ||
"vueIndentScriptAndStyle": false, | ||
"experimentalTernaries": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider specifying a parser in the ESLint configuration, such as
@typescript-eslint/parser
, to ensure proper linting of TypeScript files.