Skip to content

Commit

Permalink
cleanup stale todo's (#9028)
Browse files Browse the repository at this point in the history
Removed the SlashingProtectedValidatorSource todo as its had several PRs from bots, and it's actually grossly over-simplifying.

Re-worded to remove TODO in EraFile, as its just a POC, and we won't be accepting any tiny changes there, the note was for when its rewritten.

Removed the TODO from SszCollectionSchema but left the content, as it does seem valid.

remove stale reference to a PR #3356
Fixes #7532

Signed-off-by: Paul Harris <paul.harris@consensys.net>
rolfyone authored Jan 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 8117ebf commit d9b07ea
Showing 6 changed files with 3 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -214,7 +214,7 @@ private void verifyBlocksWithReferenceState(
block.getParentRoot().equals(previousArchiveLastBlock.getRoot()),
"First block in archive does not match last block of previous archive.");
}
// TODO should verify signature
// when fully implemented, we would check signature also
++populatedSlots;
}
System.out.println(
Original file line number Diff line number Diff line change
@@ -97,7 +97,6 @@ public void changeSpecConfigTest() {

@Test
void roundTripViaSsz() {
// TODO - generate random version-specific state
BeaconState beaconState = randomState();
Bytes bytes = beaconState.sszSerialize();
BeaconState state = schema.sszDeserialize(bytes);
Original file line number Diff line number Diff line change
@@ -49,7 +49,6 @@ default SszCollectionT createFromElements(final List<? extends SszElementT> elem
}

default TreeNode createTreeFromElements(final List<? extends SszElementT> elements) {
// TODO: probably suboptimal method implementation:
// This is a generic implementation which works for both Vector and List but it potentially
// could do better if construct the tree directly in List/Vector subclasses
checkArgument(elements.size() <= getMaxLength(), "Too many elements for this collection type");
Original file line number Diff line number Diff line change
@@ -54,8 +54,6 @@ class ScoringConfig {

private ScoringConfig(final Spec spec, final int d) {
this.spec = spec;
// TODO(#3356) Use spec provider through-out rather than relying only on genesis constants and
// genesis spec
this.genesisConfig = spec.getGenesisSpecConfig();
this.genesisSpec = spec.getGenesisSpec();
this.d = d;
Original file line number Diff line number Diff line change
@@ -215,11 +215,9 @@ protected Host createHost(final PrivKey privKey, final List<Multiaddr> advertise
b.getTransports().add(TcpTransport::new);
b.getSecureChannels().add(NoiseXXSecureChannel::new);

// yamux MUST take precedence during negotiation
// Yamux must take precedence during negotiation
if (config.isYamuxEnabled()) {
// TODO: https://github.com/Consensys/teku/issues/7532
final int maxBufferedConnectionWrites = 150 * 1024 * 1024;
b.getMuxers().add(StreamMuxerProtocol.getYamux(maxBufferedConnectionWrites));
b.getMuxers().add(StreamMuxerProtocol.getYamux());
}
b.getMuxers().add(StreamMuxerProtocol.getMplex());

Original file line number Diff line number Diff line change
@@ -90,8 +90,6 @@ public boolean isReadOnly() {

@Override
public Signer createSigner() {
// TODO: Consider caching these to guarantee we can't possible use different
// `SlashingProtectedSigner` instances with the same key
return new SlashingProtectedSigner(
getPublicKey(), slashingProtector, delegate.createSigner());
}

0 comments on commit d9b07ea

Please sign in to comment.