cleanup stale todo's #9028
cleanup stale todo's #9028
Conversation
Removed the SlashingProtectedValidatorSource todo as its had several PRs from bots, and it's actually grossly over-simplifying. Re-worded to remove TODO in EraFile, as its just a POC, and we won't be accepting any tiny changes there, the note was for when its rewritten. Removed the TODO from SszCollectionSchema but left the content, as it does seem valid. remove stale reference to a PR Consensys#3356 Fixes Consensys#7532 Signed-off-by: Paul Harris <paul.harris@consensys.net>
| @@ -49,7 +49,6 @@ default SszCollectionT createFromElements(final List<? extends SszElementT> elem | |||
| } | |||
|
|
|||
| default TreeNode createTreeFromElements(final List<? extends SszElementT> elements) { | |||
| // TODO: probably suboptimal method implementation: | |||
There was a problem hiding this comment.
I'd leave the comment of this being prob a suboptimal impl
There was a problem hiding this comment.
we can just re-visit that, we have lots of sub-optimal implementations of things IMO
There was a problem hiding this comment.
Problem is how we will revisit it if the comment is gone. Possibly raise an issue?
There was a problem hiding this comment.
Literally 80% of our code is in the same spot.... We typically don't write optimised code because the spec isn't optimised, and I dont think commenting every non-optimised section of code is going to leave readable code.
There was a problem hiding this comment.
also please note the entire comment of the reasoning is there if you look at the next lines. its just the 'probably suboptimal' that is gone.
added more noise with #9035 to also track onthe board but i think where i left it was more than adequate. am marking this thread resolved.
Removed the SlashingProtectedValidatorSource todo as its had several PRs from bots, and it's actually grossly over-simplifying.
Re-worded to remove TODO in EraFile, as its just a POC, and we won't be accepting any tiny changes there, the note was for when its rewritten.
Removed the TODO from SszCollectionSchema but left the content, as it does seem valid.
remove stale reference to a PR #3356
Fixes #7532
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog