Add dynamic to optimize #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blanchco
approved these changes
Jan 31, 2025
mwdchang
approved these changes
Jan 31, 2025
liunelson
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we provide optimize with a dynamic parameter within the fixed interventions (the interventions that are not being optimized over) we should convert it to the ciemss format and send it off with payload
Warning:
This seems to severely increases runtime of the optimize call.
Testing:
Run an optimize call with and without dynamic interventions provided
Check the pyciemss-worker converts the dynamic interventions
Check that the results differ between the two runs in the expected way