Feat: improve rotated inset support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aleaf
commented
Mar 8, 2024
aleaf
commented
- add support for generating grids with a specified rotation around features of interest
- add support for rotated LGR models (LGR parent and inset with same rotation)
- generalize logic of snapping inset grids to parent grids to ensure that the inset grid is symmetrical about nearfield features of interest when it is created from those (using a buffer; instead of by specifying offset and nrow, ncol)
- other clean-up refactoring and improvements to testing
* load at least the dis, tdis and sto package (MF6 models only) in initial setup of parent model, to ensure that the modeltime.steady_state values are accurate * handle different MF6/'old' Flopy behavior with dis.nlay * kruft removal feat(mf6model.py): allow specification of LGR inset configuration directly (as additional YAML or a dictionary in-memory) for easier testing fix(mf6model.py): * handle Flopy issue with .modeltime attribute displaying True for each period in steady_state dict with an entry * fix error in stress period data setup when loading time dis information from parent model (when it isn't specified in inset model config); by removing perlen=1 from defaults
…patial reference against DIS package; and override_dis_package_input configuration option for when an existing model lacks valid sr information in the DIS package
* add support for generating grids with a specified rotation around features of interest * add support for rotated LGR models (LGR parent and inset with same rotation) * generalize logic of snapping inset grids to parent grids to ensure that the inset grid is symmetrical about nearfield features of interest when it is created from those (using a buffer; instead of by specifying offset and nrow, ncol) * fix(grid.py::setup_structured_grid): some issues with delr/delc input, esp. when model.setup_grid is called more than once. * refactor(grid.py::setup_structured_grid): kruft removal * improved testing and error checking for various rotated grid cases: * inset and TMR parent with same rotation * inset rotated relative to TMR parent * LGR inset rotated relative to LGR parent (not allowed; raise error)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #79 +/- ##
===========================================
+ Coverage 89.14% 89.31% +0.16%
===========================================
Files 64 64
Lines 12396 12545 +149
===========================================
+ Hits 11050 11204 +154
+ Misses 1346 1341 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.