Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: improve rotated inset support #79

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Feat: improve rotated inset support #79

merged 4 commits into from
Mar 8, 2024

Commits on Mar 8, 2024

  1. fix(mfmodel.py): 

    * load at least the dis, tdis and sto package (MF6 models only) in initial setup of parent model, to ensure that the modeltime.steady_state values are accurate
* handle different MF6/'old' Flopy behavior with dis.nlay
* kruft removal
feat(mf6model.py): allow specification of LGR inset configuration directly (as additional YAML or a dictionary in-memory) for easier testing
fix(mf6model.py):
* handle Flopy issue with .modeltime attribute displaying True for each period in steady_state dict with an entry
* fix error in stress period data setup when loading time dis information from parent model (when it isn't specified in inset model config); by removing perlen=1 from defaults
    @aleaf
    aleaf committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5578e49 View commit details
    Browse the repository at this point in the history

  2. feat(mfmodel.py): add validation of configuration file parent model s… 

    …patial reference against DIS package; and override_dis_package_input configuration option for when an existing model lacks valid sr information in the DIS package
    @aleaf
    aleaf committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    53ebfe3 View commit details
    Browse the repository at this point in the history

  3. "feat(improved support for insetting with rotated grids): 

    * add support for generating grids with a specified rotation around features of interest
* add support for rotated LGR models (LGR parent and inset with same rotation)
* generalize logic of snapping inset grids to parent grids to ensure that the inset grid is symmetrical about nearfield features of interest when it is created from those (using a buffer; instead of by specifying offset and nrow, ncol)
* fix(grid.py::setup_structured_grid): some issues with delr/delc input, esp. when model.setup_grid is called more than once.
* refactor(grid.py::setup_structured_grid): kruft removal
* improved testing and error checking for various rotated grid cases:
  * inset and TMR parent with same rotation
  * inset rotated relative to TMR parent
  * LGR inset rotated relative to LGR parent (not allowed; raise error)
    @aleaf
    aleaf committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e824f69 View commit details
    Browse the repository at this point in the history

  4. refactor(ic.py): default to 'linear' resampling method for initial co… 

    …nditions
    @aleaf
    aleaf committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    80d649d View commit details
    Browse the repository at this point in the history