-
Notifications
You must be signed in to change notification settings - Fork 24
Add icon custom width and height #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
any update on this? Also, what else is missing for this PR to be put as open and approved? |
It is a draft, as this was just an initial implementation I did, but it has a couple of drawbacks, such as default Blizzard glows showing as a 1 by 1 square, until the initial animation is over. Other than that, it also needs to be optimized to reduce the number of calls to the calculate texcoords function, as swapping specs lags the game out for a solid 2+ seconds. @DaleHuntGB said he will work on custom glows when he gets to it, and part of that is custom width/height implementation. This branch is basically just a reference for him to look at. I'm personally using this branch since it works fine outside of the spec swapping, and I can live with the animation being weird for 200ms. |
WowT_zXR8B2bC8E.mp4